feat: add extensibility points for HttpContent matchers#466
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adds predicate-based extensibility points for matching HttpContent bodies, updates tests/docs accordingly, and adjusts the public API surface to reflect the new matcher options.
Changes:
- Added predicate overloads for matching string and binary
HttpContentbodies. - Updated/extended
HttpClient/HttpRequestMessagematcher tests and renamed string-related test cases for clarity. - Updated documentation and API expectation snapshots; removed the old
WithBytesContainingsurface.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| Tests/Mockolate.Tests/Web/ItExtensionsTests.IsHttpRequestMessageTests.WhoseContentIsTests.cs | Adds new request-content predicate tests and renames string matcher tests. |
| Tests/Mockolate.Tests/Web/ItExtensionsTests.IsHttpContentTests.WithStringTests.cs | Adds predicate-based WithString tests and removes an unused regex using. |
| Tests/Mockolate.Tests/Web/ItExtensionsTests.IsHttpContentTests.WithBytesTests.cs | Adds predicate-based WithBytes tests. |
| Tests/Mockolate.Tests/Web/ItExtensionsTests.IsHttpContentTests.WithBytesContainingTests.cs | Removes tests for the removed WithBytesContaining API. |
| Tests/Mockolate.Api.Tests/Expected/Mockolate_netstandard2.0.txt | Updates expected API surface for netstandard2.0. |
| Tests/Mockolate.Api.Tests/Expected/Mockolate_net8.0.txt | Updates expected API surface for net8.0. |
| Tests/Mockolate.Api.Tests/Expected/Mockolate_net10.0.txt | Updates expected API surface for net10.0. |
| Source/Mockolate/Web/ItExtensions.HttpContent.cs | Implements predicate-based matchers for string/bytes and removes WithBytesContaining. |
| README.md | Documents new predicate-based matcher overloads and removes WithBytesContaining. |
| Docs/pages/special-types/01-httpclient.md | Mirrors README docs update for new overloads and removed API. |
🚀 Benchmark ResultsDetails
|
|
|
This is addressed in release v1.4.0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds predicate-based extensibility points for matching
HttpContentbodies, updates tests/docs accordingly, and adjusts the public API surface to reflect the new matcher options.Key Changes:
HttpContentbodies.HttpClient/HttpRequestMessagematcher tests and renamed string-related test cases for clarity.WithBytesContainingsurface.HttpContent#465